Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw RegexParseException after failed nginx log match #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Throw RegexParseException after failed nginx log match #5

wants to merge 1 commit into from

Conversation

htfy96
Copy link
Collaborator

@htfy96 htfy96 commented Sep 23, 2016

Fixed #3

@htfy96
Copy link
Collaborator Author

htfy96 commented Sep 23, 2016

@lv-zheng Could you please review this PR at https://github.com/sjtug/nginx-simple-watcher/pull/5/files?

lv-zheng
lv-zheng approved these changes Sep 27, 2016
View reviewed changes
Copy link
Contributor

@lv-zheng lv-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not spared my time to test this code. The code seems nice and it should work. How about forcing the status code to be 2xx or 3xx?

@htfy96
Copy link
Collaborator Author

htfy96 commented Sep 27, 2016

@lv-zheng I'd prefer keeping them. Error response deserves more attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lv-zheng lv-zheng lv-zheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@htfy96 @lv-zheng